| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Assertion for logically decoding multi inserts into the catalog |
| Date: | 2019-07-08 19:42:23 |
| Message-ID: | CBFFD532-C033-49EB-9A5A-F67EAEE9EB0B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
My patch for using heap_multi_insert in the catalog [1] failed the logical
decoding part of test/recovery [2].
The assertion it failed on seems to not take multi inserts into the catalog
into consideration, while the main logic does. This assertion hasn't tripped
since there are no multi inserts into the catalog, but if we introduce them it
will so I’m raising it in a separate thread as it is sort of unrelated from the
patch in question.
The attached patch fixes my test failure and makes sense to me, but this code
is far from my neck of the tree, so I’m really not sure this is the best way to
express the assertion.
cheers ./daniel
[1] https://commitfest.postgresql.org/23/2125/
[2] https://postgr.es/m/CA+hUKGLg1vFiXnkxjp_bea5+VP8D=vHRwSdvj7Rbikr_u4xFbg@mail.gmail.com
| Attachment | Content-Type | Size |
|---|---|---|
| logdec_assert.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-07-08 19:47:33 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |
| Previous Message | Tom Lane | 2019-07-08 19:38:13 | Re: Declared but no defined functions |