Re: numeric_big in make check?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: numeric_big in make check?
Date: 2024-02-19 12:31:03
Message-ID: CB66FBCC-3D99-4046-83CF-EAD251A4B225@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 19 Feb 2024, at 12:48, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:

>> To make sure it's executed and not silently breaks, is it time to add this to
>> the regular make check?
>
> Or we could just flush it. It's never detected a bug, and I think
> you'd find that it adds zero code coverage (or if not, we could
> fix that in a far more surgical and less expensive manner).

I don't have a problem with that, there isn't much value in keeping it
(especially when not connected to make check so that it actually runs). That
also means we can remove two make targets which hadn't been ported to meson to
get us a hair closer to parity.

--
Daniel Gustafsson

Attachment Content-Type Size
v1-0001-Remove-numeric_big-test-suite.patch application/octet-stream 708.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2024-02-19 12:53:26 Re: POC, WIP: OR-clause support for indexes
Previous Message Ashutosh Bapat 2024-02-19 12:25:28 Re: Memory consumed by paths during partitionwise join planning