| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Onder Kalaci <onder(at)citusdata(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Date: | 2018-08-11 22:17:59 |
| Message-ID: | CB576655-AF5D-4EDD-827F-88EE39CFF32A@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Aug 2018, at 09:47, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> Has there been any consideration to encodings?
Thats a good point, no =/
> What happens if the message contains non-ASCII characters, and the sending backend is connected to database that uses a different encoding than the backend being signaled?
In the current state of the patch, instead of the message you get:
FATAL: character with byte sequence 0xe3 0x82 0xbd in encoding "UTF8" has
no equivalent in encoding “ISO_8859_5"
Thats clearly not good enough, but I’m not entirely sure what would be the best
way forward. Restrict messages to only be in SQL_ASCII? Store the encoding of
the message and check the encoding of the receiving backend before issuing it
for a valid conversion, falling back to no message in case there is none?
Neither seems terribly appealing, do you have any better suggestions?
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-08-11 23:32:51 | Re: NetBSD vs libxml2 |
| Previous Message | Noah Misch | 2018-08-11 21:08:47 | Re: Facility for detecting insecure object naming |