| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump handling of ALTER DEFAULT PRIVILEGES IN SCHEMA |
| Date: | 2021-09-06 06:31:10 |
| Message-ID: | CB238615-646A-4CCD-B027-14E7CB2EAF50@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/5/21, 12:58 PM, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote:
> On 9/5/21, 12:14 PM, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'd be inclined to split this logic out into a separate if-statement,
>> along the lines of
>
> Got it, thanks.
Attached is an attempt at cleaning the patch up and adding an
informative comment and a test case.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-pg_dump-handling-of-ALTER-DEFAULT-PRIVILEGES-.patch | application/octet-stream | 11.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-09-06 06:36:33 | Re: stat() vs ERROR_DELETE_PENDING, round N + 1 |
| Previous Message | Amit Kapila | 2021-09-06 05:56:15 | Re: Added missing invalidations for all tables publication |