| From: | Lev Kokotov <lev(dot)kokotov(at)gmail(dot)com> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Bug in pgbench prepared statements |
| Date: | 2023-12-01 03:15:54 |
| Message-ID: | CAPwLVyKmWHA9CGEQyKEZuXrSoDGCqy+cNM+-uLAcwRrFysRpJQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I see prepareCommand() is called one more time in
> prepareCommandsInPipeline(). Should you also check the return value
> there?
Yes, good catch. New patch attached.
> It may also be useful to throw this patch on the January commitfest if
> no one else comes along to review/commit it.
First time contributing, not familiar with the process here, but happy to
learn.
Best,
On Thu, Nov 30, 2023 at 2:10 PM Tristan Partin <tristan(at)neon(dot)tech> wrote:
> On Wed Nov 29, 2023 at 7:38 PM CST, Lev Kokotov wrote:
> > Patch attached, if there is any interest in fixing this small bug.
>
> I see prepareCommand() is called one more time in
> prepareCommandsInPipeline(). Should you also check the return value
> there?
>
> It may also be useful to throw this patch on the January commitfest if
> no one else comes along to review/commit it. This first set of changes
> looks good to me.
>
> --
> Tristan Partin
> Neon (https://neon.tech)
>
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench.patch | application/octet-stream | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-12-01 03:18:15 | Re: optimize atomic exchanges |
| Previous Message | Andrei Lepikhov | 2023-12-01 02:57:13 | Re: Report planning memory in EXPLAIN ANALYZE |