From: | Sascha Kuhl <yogidabanli(at)gmail(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: wait event and archive_command |
Date: | 2021-11-10 11:25:58 |
Message-ID: | CAPvVvKDh29hnjOn8r+JvsPjYFkf0pxwzmPj18F2vj6Jfutg=Aw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Great, so great. Thanks you
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> schrieb am Mi.,
10. Nov. 2021, 12:20:
> On Mon, Nov 1, 2021 at 2:31 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
> wrote:
> > On 2021/10/21 23:55, Bharath Rupireddy wrote:
> > >> Also how about adding wait events for other commands like
> > >> archive_cleanup_command, restore_command and recovery_end_command?
> > >
> > > +1 for the wait event.
> >
> > Thanks!
> > I added the wait events for also restore_command, etc into the patch.
> > I attached that updated version of the patch.
>
> Thanks for the patch. It looks good to me other than the following comment:
>
> 1) Can't we determine the wait event type based on commandName in
> ExecuteRecoveryCommand instead of passing it as an extra param?
>
> Regards,
> Bharath Rupireddy.
>
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-11-10 11:28:59 | Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY |
Previous Message | Bharath Rupireddy | 2021-11-10 11:19:54 | Re: wait event and archive_command |