Re: [PATCH] Use maintenance_io_concurrency for parallel index builds

From: Jingtang Zhang <mrdrivingduck(at)gmail(dot)com>
To: Yuhang Qiu <iamqyh(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Melanie Plageman <melanieplageman(at)gmail(dot)com>
Subject: Re: [PATCH] Use maintenance_io_concurrency for parallel index builds
Date: 2026-09-09 12:40:23
Message-ID: CAPsk3_AfS4wKS2yOkOYOanX57xA7+JtR8vDBF3dXncs5zgJ3cA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Actually, no extension is needed: table_beginscan_common() already
> accepts user_flags, so heapam_index_build_range_scan() can simply
> call it directly and pass SO_MAINTENANCE.
>
> BRIN's summarize_range() also goes through
> heapam_index_build_range_scan(), so fixing the serial path would
> switch it over. IMO, that counts as maintenance too.

Thanks for the review. Attached is v3, which also handles serial index
builds by calling table_beginscan_common() directly, as you suggested.
This covers BRIN range summarization too, without changing the API.

---
Regards,
Jingtang Zhang

Attachment Content-Type Size
v3-index-maintenance-io.patch application/octet-stream 5.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message solai v 2026-09-09 12:42:22 Re: Include sequences in publications created by pg_createsubscriber
Previous Message Diego 2026-09-09 12:33:16 Re: [PATCH] libpq: Add PQpassfileLookup()