Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shubham Barai <shubhambaraiss(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Borodin <amborodin86(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index
Date: 2018-03-11 18:32:08
Message-ID: CAPpHfdvz3g7j+EjhceGX6SfQstU_uE3yayckieOz+RTv0OVRDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 2, 2018 at 6:57 AM, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
wrote:

> My thought experiments about pseudo-pages and avoiding the split stuff
> were not intended to get the patch kicked out. I thought for a while
> that hash indexes were a special case and could benefit from
> dispensing with those trickier problems. Upon further reflection, for
> interesting size hash indexes pure hash value predicate tags wouldn't
> be much better. Furthermore, if we do decide we want to use using x %
> max_predicate_locks_per_relation to avoid having to escalate to
> relation predicate locks at the cost of slightly higher collision rate
> then we should consider that for the whole system (including heap page
> predicate locking), not just hash indexes. Please consider those
> ideas parked for now.

OK. While our potential pseudo-pages are identified as
"hash_value % some_constant_modulus", real bucket pages are very roughly
identified as "hash_value % number_of_index_pages". So, page number is
adoptive to index size, despite it costs us handling page split. In the
same way,
locking in other index access methods is adoptive to an index size, so
that should be considered as useful feature which should be present in hash
index
as well.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-03-11 18:48:57 Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index
Previous Message Dave Page 2018-03-11 18:26:43 Re: [GSOC 18] Performance Farm Project——Initialization Project