| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Custom tuplesorts for extensions |
| Date: | 2022-07-24 21:52:49 |
| Message-ID: | CAPpHfdvr2m7aCjm9fy+4pdah9su3-Hp5mDDYBsoYtkbdOnkOVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jul 24, 2022 at 3:24 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> Also, my OrioleDB colleagues Ilya Kobets and Tatsiana Yaumenenka run
> tests to check if the patchset causes a performance regression. The
> script and results are present in the "tuplesort_patch_test.zip"
> archive. The final comparison is given in the result/final_table.txt.
> In short, they repeat each test 10 times and there is no difference
> exceeding the random variation.
I see the last revision passed cfbot without warnings. I've added the
meta information to commit messages. Also, I've re-run through the
thread and it seems all the comments are addressed. I'm going to push
this if there are no objections.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0004-Move-memory-management-away-from-writetup-and-tup-v5.patch | application/x-patch | 8.4 KB |
| 0002-Add-new-Tuplesortstate.removeabbrev-function-v5.patch | application/x-patch | 10.6 KB |
| 0005-Split-TuplesortPublic-from-Tuplesortstate-v5.patch | application/x-patch | 69.9 KB |
| 0001-Remove-Tuplesortstate.copytup-function-v5.patch | application/x-patch | 16.9 KB |
| 0003-Put-abbreviation-logic-into-puttuple_common-v5.patch | application/x-patch | 10.9 KB |
| 0006-Split-tuplesortvariants.c-from-tuplesort.c-v5.patch | application/x-patch | 117.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-24 22:18:03 | Re: 012_subtransactions.pl vs clang -fsanitize=undefined |
| Previous Message | Tom Lane | 2022-07-24 21:50:59 | Re: 012_subtransactions.pl vs clang -fsanitize=undefined |