| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2026-06-15 21:36:56 |
| Message-ID: | CAPpHfdvpzvNt=d_Csxe-TCtvF9MRNdeMtfJu3RkmTgBkkQbGUw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 16, 2026 at 12:36 AM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> On Tue, 16 Jun 2026 at 00:50, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > On Mon, Jun 15, 2026 at 2:07 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > >
> > > I hit an error when I tried this patch.
> > >
> > > CREATE TABLE a (a text) PARTITION BY RANGE(a);
> > > CREATE TABLE a1 PARTITION OF a DEFAULT;
> > > INSERT INTO a SELECT repeat('1', 9999999);
> > > CREATE TABLE a2 PARTITION OF a FOR VALUES FROM (2)TO(3);
> > > ALTER TABLE a MERGE PARTITIONS (a1, a2) INTO a1;
> > > ERROR: row is too big: size 39264, maximum size 8160
> >
> > Thank you for your report. It appears that createPartitionTable()
> > misses NewRelationCreateToastTable() call (for instance, DefineTable()
> > has this call). The attached patch implements fix and has tests. I'm
> > going to push it if no objections.
>
> It looks like the patch is missing in the last message.
Sorry, here it is.
------
Regards,
Alexander Korotkov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Create-TOAST-table-for-partitions-made-by-MERGE-S.patch | application/octet-stream | 7.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-06-15 21:45:42 | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Previous Message | Pavel Borisov | 2026-06-15 21:36:08 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |