| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2025-12-09 15:14:44 |
| Message-ID: | CAPpHfdvpzezTnuumpdJYge=x1TbhgAkjMGh2GHnScf5SFsf2ew@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Fri, Oct 31, 2025 at 5:41 PM Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> wrote:
>
> Hi Alexander!
>
> >How this function could handle this case?
> >
> >list1: (NULL)
> >list2: whatever containing NULL
> >
> >The outer loop will just quit after iterating the only element of
> >list1 without even iterating list2.
>
> Thanks for the case!
> Patches with the fix are attached to email.
I went though the patchset and did a lot of cleaning and grammar
corrections for comments and commit messages. During the previous
attempt for this patch, I had to revert it mainly because of the
security issue caused by repeated table lookup by its name. The
present version doesn't have this problem, because it doesn't do the
repeated lookup. Additionally, the patchset went through many series
of detailed review. I dare give this patchset another chance. I'm
going to push this if no objections.
------
Regards,
Alexander Korotkov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| v65-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch | application/octet-stream | 171.8 KB |
| v65-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch | application/octet-stream | 234.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2025-12-09 15:23:11 | Re: Add wait event for CommitDelay |
| Previous Message | Dilip Kumar | 2025-12-09 15:11:21 | Re: Proposal: Conflict log history table for Logical Replication |