| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mikhail Gribkov <youzhick(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: On login trigger: take three |
| Date: | 2024-01-17 21:25:02 |
| Message-ID: | CAPpHfdve2Z7e+MsHNk=ddYk-AUwjs7=v9fyMdoRV=Ooysfqo5g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 15, 2024 at 11:29 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 13 Jan 2024, at 17:00, Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> > I suspected that this failure was caused by autovacuum, and I've managed to
> > reproduce it without Valgrind or slowing down a machine.
>
> This might be due to the fact that the cleanup codepath to remove the flag when
> there is no login event trigger doesn't block on locking pg_database to avoid
> stalling connections. There are no guarantees when the flag is cleared, so a
> test like this will always have potential to be flaky it seems.
+1
Thank you, Daniel. I think you described everything absolutely
correctly. As I wrote upthread, it doesn't seem much could be done
with this, at least within a regression test. So, I just removed this
query from the test.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2024-01-17 21:31:12 | Re: Emit fewer vacuum records by reaping removable tuples during pruning |
| Previous Message | Alexander Korotkov | 2024-01-17 21:08:39 | Re: Assertion failure with epoch when replaying standby records for 2PC |