| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Alyona Vinter <dlaaren8(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Resetting recovery target parameters in pg_createsubscriber |
| Date: | 2025-09-15 07:29:47 |
| Message-ID: | CAPpHfdvaS80t9174rJ5gdpwosmz0_sAK9OYtiKWXKPYymHR_og@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, Alyona!
On Mon, Sep 8, 2025 at 8:35 AM Alyona Vinter <dlaaren8(at)gmail(dot)com> wrote:
>
> Sorry, wrong patches again. Here are the correct ones.
I went though this patches.
1) I've removed the array of parameters. I see it was proposed by
Michael upthread. But I think his proposal came from the fact we walk
trough the parameters twice. But we end up walking trough the
parameter once in setup_recovery(), while reset_recovery_params() just
restores the previous contents. I think it makes sense to keep the
changes minimal.
2) I reordered patches so that helper function goes first. I think it
essential to order commit in the way that every commit leaves our tree
in working state.
3) I make pgpreltidy run over 040_pg_createsubscriber.pl.
Any thought?
------
Regards,
Alexander Korotkov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Implements-helper-function-in-recovery_gen.patch | application/octet-stream | 3.5 KB |
| v4-0002-Reseting-recovery-target-parameters-in-pg_creates.patch | application/octet-stream | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-09-15 07:36:56 | RE: Conflict detection for update_deleted in logical replication |
| Previous Message | Peter Eisentraut | 2025-09-15 06:36:22 | Re: --with-llvm on 32-bit platforms? |