| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2026-06-15 20:50:07 |
| Message-ID: | CAPpHfdvOvaPxMoUp3T6hf4UmAaOhdPCcw71OGUWDjTXvrTZ_JA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 15, 2026 at 2:07 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> I hit an error when I tried this patch.
>
> CREATE TABLE a (a text) PARTITION BY RANGE(a);
> CREATE TABLE a1 PARTITION OF a DEFAULT;
> INSERT INTO a SELECT repeat('1', 9999999);
> CREATE TABLE a2 PARTITION OF a FOR VALUES FROM (2)TO(3);
> ALTER TABLE a MERGE PARTITIONS (a1, a2) INTO a1;
> ERROR: row is too big: size 39264, maximum size 8160
Thank you for your report. It appears that createPartitionTable()
misses NewRelationCreateToastTable() call (for instance, DefineTable()
has this call). The attached patch implements fix and has tests. I'm
going to push it if no objections.
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marcos Pegoraro | 2026-06-15 21:04:43 | Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements |
| Previous Message | Laurenz Albe | 2026-06-15 20:41:15 | Re: Adding a stored generated column without long-lived locks |