| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Shubham Barai <shubhambaraiss(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Borodin <amborodin86(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: GSoC 2017: weekly progress reports (week 8) |
| Date: | 2017-09-28 11:22:18 |
| Message-ID: | CAPpHfdv9F_gKvXMj7WvAgjX0UrNmY8N5BvhVPpqBTc01QECBsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Fri, Jul 28, 2017 at 7:58 AM, Shubham Barai <shubhambaraiss(at)gmail(dot)com>
wrote:
> I am attaching a patch for predicate locking in SP-Gist index
>
I took a look over this patch.
newLeafBuffer = SpGistGetBuffer(index,
> GBUF_LEAF | (isNulls ? GBUF_NULLS : 0),
> Min(totalLeafSizes,
> SPGIST_PAGE_CAPACITY),
> &xlrec.initDest);
> PredicateLockPageSplit(index,
> BufferGetBlockNumber(current->buffer),
> BufferGetBlockNumber(newLeafBuffer));
>
You move predicate lock during split only when new leaf page is allocated.
However SP-GiST may move items to the free space of another busy page
during split (see other branches in doPickSplit()). Your patch doesn't
seem to handle this case correctly.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2017-09-28 12:15:29 | Another oddity in handling of WCO constraints in postgres_fdw |
| Previous Message | Alexander Korotkov | 2017-09-28 10:59:51 | Re: GSoC 2017 : Patch for predicate locking in Gist index |