Re: unnesting multirange data types

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: unnesting multirange data types
Date: 2021-06-17 19:28:36
Message-ID: CAPpHfdv7q8GN=W9jHLNABEqVWG6J52Y0R7k_jnqEZO44jX=4Fw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 17, 2021 at 7:54 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> On Wed, Jun 16, 2021 at 3:44 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > On Tue, Jun 15, 2021 at 8:18 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > > Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > > > I did run "check-world", but it passed for me. Probably the same
> > > > reason it passed for some buildfarm animals...
> > >
> > > It looks to me like the proximate problem is that you should
> > > have taught pg_dump to skip these new auto-generated functions.
> >
> > Yes, it appears that pg_dump skips auto-generated functions, but
> > doesn't skip auto-generated casts. It appears to be enough to tune
> > query getCasts() to resolve the issue. The revised patch is attached.
>
> Here is the next revision of the patch: I've adjusted some comments.
>
> In my point of view this patch is not actually complex. The reason
> why it colored buildfarm in red is purely my fault: I messed up with
> "make check-world" :(
>
> I've registered it on the commitfest application to make it go through
> commitfest.cputube.org. My proposal is to re-push it once it goes
> through commitfest.cputube.org.

Patch successfully passed commitfest.cputube.org. I'm going to
re-push it if there are no objections.

------
Regards,
Alexander Korotkov

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-06-17 19:47:22 Re: Add version macro to libpq-fe.h
Previous Message Andres Freund 2021-06-17 19:25:43 Re: Centralizing protective copying of utility statements