Re: Flexible configuration for full-text search

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Flexible configuration for full-text search
Date: 2018-08-24 15:50:38
Message-ID: CAPpHfdv1hQ=4LKput=4MQtpzbbN7Kd8WD_+-6sKi8T2zX3uqSA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 24, 2018 at 1:13 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> writes:
> > On Fri, Apr 6, 2018 at 10:52 AM Aleksandr Parfenov
> > <a(dot)parfenov(at)postgrespro(dot)ru> wrote:
> >> The key point of the patch is to process stopwords the same way as
> >> others at the level of the PostgreSQL internals and give users an
> >> instrument to process them in a special way via configurations.
>
> > If we're going to do it that way by providing separate dictionaries
> > for stop words, then I think we should also make it for builtin
> > dictionaries and configurations. So, I think this patch should also
> > split builtin dictionaries into stemmers and stop word dictionaries,
> > and provide corresponding configuration over them. It would be also
> > needed to perform some benchmarking to show that new way of defining
> > configurations is not worse than previous way in the performance.
>
> I'm hesitant about the backwards-compatibility aspects of this.
> Yes, we could set up the standard text search configurations to still
> work the same as before, but how will you do it without breaking existing
> custom configurations that use those dictionaries?

Agreed, backward compatibility is important here. Probably we should
leave old dictionaries for that. But I just meant that if we
introduce new (better) way of stop words handling and encourage users
to use it, then it would look strange if default configurations work
the old way...

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-08-24 15:53:14 Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept
Previous Message Tom Lane 2018-08-24 15:47:43 Re: remove ATTRIBUTE_FIXED_PART_SIZE