From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
---|---|
To: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add missing operator <->(box, point) |
Date: | 2019-07-08 15:22:21 |
Message-ID: | CAPpHfdv-oc10OsXyKuj5LHG9cFK2Wi0uMS3A-rjUs-q4mY9QFQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 11, 2019 at 2:49 AM Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> wrote:
> 2. Add <-> to GiST box_ops.
> Extracted gist_box_distance_helper() common for gist_box_distance() and
> gist_bbox_distance().
For me it doesn't look worth having two distinct functions
gist_box_distance_helper() and gist_bbox_distance(). What about
having just one and leave responsibility for recheck flag to the
caller?
> 3. Add <-> to SP-GiST.
> Changed only catalog and tests. Box case is already checked in
> spg_box_quad_leaf_consistent():
> out->recheckDistances = distfnoid == F_DIST_POLYP;
So, it seems to be fix of oversight in 2a6368343ff4. But assuming
fixing this requires catalog changes, we shouldn't backpatch this.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2019-07-08 15:25:10 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |
Previous Message | Joe Conway | 2019-07-08 15:18:01 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |