Re: Operator class parameters and sgml docs

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Operator class parameters and sgml docs
Date: 2020-06-16 11:24:05
Message-ID: CAPpHfdukTDQqWRjqh58rfQ7Pa0G6-hag8Eiwkb4=f3srhSRDSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 28, 2020 at 11:02 PM Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>
> On Thu, May 21, 2020 at 3:17 AM Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> >
> > On Thu, May 21, 2020 at 12:37 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > > Commit 911e7020770 added a variety of new support routines to index
> > > AMs. For example, it added a support function 5 to btree (see
> > > BTOPTIONS_PROC), but didn't document this alongside the other support
> > > functions in btree.sgml.
> > >
> > > It looks like the new support functions are fundamentally different to
> > > the existing ones in that they exist only as a way of supplying
> > > parameters to other support functions. The idea was to preserve
> > > compatibility with the old support function signatures. Even still, I
> > > think that the new support functions should get some mention alongside
> > > the older support functions.
> > >
> > > I also wonder whether or not xindex.sgml needs to be updated to
> > > account for opclass parameters.
> >
> > Thank you for pointing. I'm going to take a look on this in next few days.
>
> I'm sorry for the delay. I was very busy with various stuff. I'm
> going to post docs patch next week.

Thank you for patience. The documentation patch is attached. I think
it requires review by native english speaker.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
opclass_options_doc.patch application/octet-stream 12.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2020-06-16 11:53:26 Re: TAP tests and symlinks on Windows
Previous Message Peter Eisentraut 2020-06-16 11:18:54 Re: factorial of negative numbers