Re: Table AM Interface Enhancements

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Table AM Interface Enhancements
Date: 2024-03-19 15:28:41
Message-ID: CAPpHfduSX=7sEP7yp_ecsjaBDogXfHgXZ75Mg802r9XoJLxJLQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 19, 2024 at 4:26 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> On Tue, 19 Mar 2024 at 21:05, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > Regarding 0005, I did apply "a storage tuples" grammar fix. Regarding
> > the rest of the things, I'd like to keep methods
> > tts_*_is_current_xact_tuple() to be similar to nearby
> > tts_*_getsysattr(). This is why I'm keeping the rest unchanged. I
> > think we could refactor that later, but together with
> > tts_*_getsysattr() methods.
> >
> > I'm going to push 0003, 0004 and 0005 if there are no objections.
> >
> > And I'll update 0001 and 0002 in their dedicated thread.
> >
>
> When I try to test the patch on Ubuntu 22.04 with GCC 11.4.0. There are some
> warnings as following:

Thank you for catching this!
Please, find the revised patchset attached.

------
Regards,
Alexander Korotkov

Attachment Content-Type Size
0010-Notify-table-AM-about-index-creation-v4.patch application/octet-stream 6.6 KB
0012-Introduce-RowRefType-which-describes-the-table-ro-v4.patch application/octet-stream 15.8 KB
0013-Introduce-RowID-bytea-tuple-identifier-v4.patch application/octet-stream 63.0 KB
0011-Let-table-AM-insertion-methods-control-index-inse-v4.patch application/octet-stream 13.5 KB
0001-Allow-locking-updated-tuples-in-tuple_update-and--v4.patch application/octet-stream 61.8 KB
0009-Let-table-AM-override-reloptions-for-indexes-buil-v4.patch application/octet-stream 6.4 KB
0008-Generalize-table-AM-API-for-INSERT-.-ON-CONFLICT-v4.patch application/octet-stream 27.5 KB
0007-Custom-reloptions-for-table-AM-v4.patch application/octet-stream 11.9 KB
0006-Generalize-relation-analyze-in-table-AM-interface-v4.patch application/octet-stream 29.4 KB
0005-Add-TupleTableSlotOps.is_current_xact_tuple-metho-v4.patch application/octet-stream 7.6 KB
0004-Allow-table-AM-tuple_insert-method-to-return-the--v4.patch application/octet-stream 3.9 KB
0003-Allow-table-AM-to-store-complex-data-structures-i-v4.patch application/octet-stream 5.6 KB
0002-Add-EvalPlanQual-delete-returning-isolation-test-v4.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-03-19 15:36:43 Re: Possibility to disable `ALTER SYSTEM`
Previous Message vignesh C 2024-03-19 15:24:19 Re: speed up a logical replica setup