| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SP-GiST for ranges based on 2d-mapping and quad-tree |
| Date: | 2012-11-02 08:47:05 |
| Message-ID: | CAPpHfduSGrOK++KvzLpHY0gpRZiNvN6CUXHfK92KEjn3-WwYCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 21, 2012 at 11:22 AM, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> On Tue, 2012-09-04 at 17:45 +0400, Alexander Korotkov wrote:
> > On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql(at)j-davis(dot)com>
> > wrote:
> > I am taking a look at this patch now. A few quick comments:
> >
> > * It looks like bounds_adjacent modifies it's by-reference
> > arguments,
> > which is a little worrying to me. The lower/upper labels are
> > flipped
> > back, but the inclusivities are not. Maybe just pass by value
> > instead?
> >
> > * Bounds_adjacent is sensitive to the argument order. Can't it
> > just take
> > bound1 and bound2?
> >
> >
> > Fixed. Patch is attached.
> >
> It looks like this is basically the same diff as v0.1. Did something get
> mixed up?
>
Right version of patch is attached.
------
With best regards,
Alexander Korotkov.
| Attachment | Content-Type | Size |
|---|---|---|
| range_spgist_adjacent-0.3.patch.gz | application/x-gzip | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2012-11-02 08:54:33 | Re: gistchoose vs. bloat |
| Previous Message | Etsuro Fujita | 2012-11-02 05:55:57 | Re: Comment typo |