| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | sivasubr(at)amazon(dot)com |
| Cc: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun |
| Date: | 2018-09-09 18:53:58 |
| Message-ID: | CAPpHfduOwLM-8DYu8j2hyF+bOvXhHCnNTjRA-KckxWot9B0sdQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 6, 2018 at 9:02 PM R, Siva <sivasubr(at)amazon(dot)com> wrote:
> I'm also running into this assert with the workload, I think my patch is
> not handling the case where the action is add items on the last segment
> of the page correctly. I'm still investigating the issue further to find
> the
> source of the bug.
>
> Meanwhile I reviewed your patch and it looks good to me. I agree that
> copying out the entire tail out to the scratch space in one shot vs copying
> out every segment reduces the number of memcpy calls and simplifies
> the solution overall. Let us go ahead with this patch.
>
Thank you for review! Pushed with minor beautification.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-09-09 21:49:59 | Re: [HACKERS] PATCH: multivariate histograms and MCV lists |
| Previous Message | Alexander Korotkov | 2018-09-09 18:52:46 | Re: [HACKERS] Bug in to_timestamp(). |