Re: Concurrency bug in amcheck

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>
Subject: Re: Concurrency bug in amcheck
Date: 2020-08-04 14:27:09
Message-ID: CAPpHfduNq4aR6Cdo7oWuGyOD46n4bG6Egd-kDWg0F2RQUXd-Ow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Peter!

On Sat, Aug 1, 2020 at 3:23 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:

> On Wed, May 13, 2020 at 4:06 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > On Mon, May 11, 2020 at 5:56 AM Alexander Korotkov
> > <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> > > Thank you. 2nd patch is proposed for master and makes btree page
> > > unlink remove all the items from the page being deleted.
> >
> > This looks good, but can we do the
> > wal_consistency_checking/btree_mask() improvement, too?
>
> You never got around to committing the second patch (or the
> wal_consistency_checking stuff). Are you planning on picking it up
> again?
>

Thank you for your reminder. Revised patch is attached. Now, the
contents of deleted btree pages isn't masked. I've checked that
installcheck passes with wal_consistency_checking='Btree'. I'm going to
push this if no objections.

------
Regards,
Alexander Korotkov

Attachment Content-Type Size
0001-Remove-btree-page-items-after-page-unlink-2.patch application/octet-stream 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2020-08-04 14:36:51 Re: WIP: BRIN multi-range indexes
Previous Message Pavel Stehule 2020-08-04 14:21:56 Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch