Partial match fix for fast scan

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Subject: Partial match fix for fast scan
Date: 2014-04-10 14:09:34
Message-ID: CAPpHfduF=hDiO0Nokpe184PCJoiBSRzZK2DNG2rLOp6RAzv6Dg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

GIN partial match appears to be broken after fast scan. Following simple
test case raises assertion failure.

create extension btree_gin;
create table test as (select id, random() as val from
generate_series(1,1000000) id);
create index test_idx on test using gin (val);
vacuum test;
select * from test where val between 0.1 and 0.9;

Attached patch fixes bugs in entryGetItem function.
I would especially point that "continue;" checks "while" condition even if
it's postfix "while". That's why I surrounded tbm_iterate with another
"while".

------
With best regards,
Alexander Korotkov.

Attachment Content-Type Size
ginfastscanfix.patch application/octet-stream 1.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ktm@rice.edu 2014-04-10 14:11:10 Re: Adding unsigned 256 bit integers
Previous Message Craig Ringer 2014-04-10 13:41:07 Re: Adding unsigned 256 bit integers