Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, zengman <zengman(at)halodbtech(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: 2025-12-20 11:26:59
Message-ID: CAPpHfduDafmBYttv6ZMacq6qpjcyOjrUOC=7DVb4_nURiWLRzQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 20, 2025 at 1:15 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> On Sat, Dec 20, 2025 at 6:42 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > Hi Kirill!
>
> > > reshke=# alter table only z merge partitions (z_1,z_2) into z_12;
> > > ALTER TABLE
> > > reshke=#
> > >
> > > ```
> > >
> > > IMO "alter table only ... merge partitions" does not make perfect
> > > sense and should be rejected rather than executed. WDYT?
> >
> > Could you, please, clarify your point? I didn't quite get it. It
> > looks like pretty basic example of merging two adjacent partitions.
> >
>
> > reshke=# alter table only z merge partitions (z_1,z_2) into z_12;
> I think it should fail, because we are not applying to table "z" itself,
> For Split/Merge partitions, we are processing the whole partitioned
> table z hierarchy.
>
> alter table z merge partitions (z_1,z_2) into z_12;
> should work.
>
> I guess the attached maybe is what Krill wants.

Thank you. I missed there is an ONLY keyword. But I'm not sure about
the error message. I don't think the problem with ONLY keyword is
that MERGE/SPLIT must be always recursive. I think opposite, it's
always non-recursive and this is why ONLY is meaningless. Otherwise,
we may decide to just leave it as it allowing ONLY.

------
Regards,
Alexander Korotkov
Supabase

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2025-12-20 11:36:11 Re: Inline non-SQL SRFs using SupportRequestSimplify
Previous Message Dilip Kumar 2025-12-20 11:20:53 Re: Proposal: Conflict log history table for Logical Replication