| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Subject: | Re: Bug in nbtree optimization to skip > operator comparisons (or < comparisons in backwards scans) |
| Date: | 2023-12-11 18:59:32 |
| Message-ID: | CAPpHfdtrX38rvS7Dk+fJ7kwVjgC5eN1n==2YxzVAy8VOvi6Z=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 11, 2023 at 5:56 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > BTW, do we really need to keep around the BTScanOpaqueData.firstPage
> > field? Why can't the call to _bt_readpage from _bt_first (and from
> > _bt_endpoint) just pass "firstPage=true" as a simple argument? Note
> > that the first call to _bt_readpage must take place from _bt_first (or
> > from _bt_endpoint). The first _bt_first call is already kind of
> > special, in a way that is directly related to this issue. I added some
> > comments about that to today's commit c9c0589fda, in fact -- I think
> > it's an important issue in general.
>
> Please, check the attached patchset.
Sorry, I forgot the attachment. Here it is.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-BTScanOpaqueData.firstPage-v2.patch | application/octet-stream | 4.9 KB |
| 0002-Fix-requiredOppositeDir-bug-v2.patch | application/octet-stream | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2023-12-11 19:59:46 | Teach predtest about IS [NOT] <boolean> proofs |
| Previous Message | Robert Haas | 2023-12-11 17:08:20 | Re: trying again to get incremental backup |