Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>
Subject: Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages
Date: 2025-07-17 21:09:29
Message-ID: CAPpHfdtegi5GOFQVjONT5VisnkH1rYv4zfMp9q5PHmjM5piRjQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 16, 2025 at 1:12 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jul 15, 2025 at 09:19:50PM +0300, Alexander Korotkov wrote:
> > Thank you for your efforts on this subject. Actually, I was planning
> > to work on pushing this after the release freeze ends for v18. I'd
> > like to do this at least for tests as they were initially committed by
> > me.
> >
> > Anyway, please, hold on pushing this for ~1 day to let me do final
> > review of this.
>
> If you want to apply all of this yourself, please feel free, of
> course.

Thank you!
I went trough the patchset. Everything looks good to me. I only did
some improvements to comments and commit messages. I'm going to push
this if no objections.

------
Regards,
Alexander Korotkov
Supabase

Attachment Content-Type Size
v5-PG17-0003-Improve-recovery-test-046_checkpoint_logical.patch application/octet-stream 1.9 KB
v5-0002-Improve-the-stability-of-the-recovery-test-047_ch.patch application/octet-stream 2.3 KB
v5-0001-Fix-infinite-wait-when-reading-a-partially-writte.patch application/octet-stream 2.8 KB
v5-0003-Reintroduce-test-046_checkpoint_logical_slot.patch application/octet-stream 6.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-07-17 21:11:16 Re: Adding basic NUMA awareness
Previous Message Masahiko Sawada 2025-07-17 20:44:11 Re: Make COPY format extendable: Extract COPY TO format implementations