Re: Bug in nbtree optimization to skip > operator comparisons (or < comparisons in backwards scans)

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bug in nbtree optimization to skip > operator comparisons (or < comparisons in backwards scans)
Date: 2023-12-24 22:50:52
Message-ID: CAPpHfdtN36UiPYbHQwYnLyOy7HJZL77qa7Ty2xxv3HdMqtyhSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 12, 2023 at 3:22 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> On Mon, Dec 11, 2023 at 6:16 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > Will you be in Prague this week? If not this might have to wait.
>
> Sorry, I wouldn't be in Prague this week. Due to my current
> immigration status, I can't travel.
> I wish you to have a lovely time in Prague. I'm OK to wait, review
> once you can. I will probably provide a more polished version
> meanwhile.

Please find the revised patchset attached. It comes with revised
comments and commit messages. Besides bug fixing the second patch
makes optimization easier to understand. Now the flag used for
skipping checks of same direction required keys is named
continuescanPrechecked and means exactly that *continuescan flag is
known to be true for the last item on the page.

Any objections to pushing these two patches?

------
Regards,
Alexander Korotkov

Attachment Content-Type Size
0002-Improvements-and-fixes-for-e0b1ee17dc-v3.patch application/octet-stream 9.9 KB
0001-Remove-BTScanOpaqueData.firstPage-v3.patch application/octet-stream 5.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2023-12-24 23:38:13 Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.
Previous Message Kevin Wang 2023-12-24 18:17:38 A tiny improvement of psql