| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix WAIT FOR LSN standby_write/standby_flush for archive recovery cases |
| Date: | 2026-04-16 07:31:01 |
| Message-ID: | CAPpHfdtKvFME6+-NPnbmQj0dYXWKD2kKm_OTrV22Oq68iYBMQw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Satyanarayana!
On Wed, Apr 15, 2026 at 9:44 AM SATYANARAYANA NARLAPURAM
<satyanarlapuram(at)gmail(dot)com> wrote:
> GetCurrentLSNForWaitType() for WAIT_LSN_TYPE_STANDBY_WRITE and
> WAIT_LSN_TYPE_STANDBY_FLUSH previously relied on the WAL receiver's
> tracked write/flush positions (GetWalRcvWriteRecPtr/GetWalRcvFlushRecPtr).
> There are two scenarios where WAIT FOR LSN queries can be stalled though
> replay is making progress. Breaking it down to two to give clarity on setups but
> the underlying problem is the same.
>
> There are two scenarios here:
>
> (1). When the standby is disconnected from the primary and switched to WAL
> archive mode, it continues to be in that mode until no more WAL is available to replay
> and then switch to streaming mode. Until then WAIT FOR LSN calls get stuck on the
> standby though replay catches up beyond the stale WAL receiver position. Switching
> XLog source from archive to streaming is separately tracked in [1].
>
> (2). In the case of Archive recovery, no WAL receiver process exists, so these
> functions return InvalidXLogRecPtr (0/0). WAIT FOR LSN with standby_flush or
> standby_write modes would always time out, even for WAL that has been
> fully replayed.
>
> Fix by falling back to the replay LSN (GetXLogReplayRecPtr) when the WAL
> receiver position is invalid or behind replay. This is correct because any
> WAL that has been replayed has necessarily already been written and flushed
> to disk. Attached the repro test case.
Please, check, similar patch is already posted here.
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | SATYANARAYANA NARLAPURAM | 2026-04-16 07:33:47 | Re: [PATCH] Fix WAIT FOR LSN standby_write/standby_flush for archive recovery cases |
| Previous Message | Dmitrii Bondar | 2026-04-16 07:15:31 | Re: Pgbench: remove synchronous prepare |