From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_atomic_exchange_u32() in ProcArrayGroupClearXid() |
Date: | 2018-09-22 13:28:21 |
Message-ID: | CAPpHfdtJ_tYwKiZBQYnwK31nogvXyWzbhAtDpSz586P3vCDN1Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Sep 22, 2018 at 9:55 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Sep 21, 2018 at 11:06 PM Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> > While investigating ProcArrayGroupClearXid() code I wonder why do we
> have this loop instead of plain pg_atomic_exchange_u32() call?
>
> We can use pg_atomic_exchange_u32 instead of a loop. In fact, clog
> code uses pg_atomic_exchange_u32 for the same purpose. I think it is
> better to make the code consistent at both places. Feel free to
> change it, otherwise, I can take care of it in a few days time.
>
Thank you for feedback. Pushed.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-09-22 16:09:40 | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |
Previous Message | Amit Kapila | 2018-09-22 13:23:23 | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |