| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Banck <mbanck(at)gmx(dot)net> |
| Subject: | Re: Berserk Autovacuum (let's save next Mandrill) |
| Date: | 2020-03-25 20:19:23 |
| Message-ID: | CAPpHfdsuPoV0ray+bgQ7FP-Ycv9v7932Y09EXyMSjqB6zf+icg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 25, 2020 at 10:26 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2020-03-25 11:05:21 -0500, Justin Pryzby wrote:
> > Since we talked about how scale_factor can be used to effectively disable this
> > new feature, I thought that scale=100 was too small and suggesed 1e10 (same as
> > max for vacuum_cleanup_index_scale_factor since 4d54543ef). That should allow
> > handling the case that analyze is disabled, or its threshold is high, or it
> > hasn't run yet, or it's running but hasn't finished, or analyze is triggered as
> > same time as vacuum.
>
> For disabling we instead should allow -1, and disable the feature if set
> to < 0.
This patch introduces both GUC and reloption. In reloptions we
typically use -1 for "disable reloption, use GUC value instead"
semantics. So it's unclear how should we allow reloption to both
disable feature and disable reloption. I think we don't have a
precedent in the codebase yet. We could allow -2 (disable reloption)
and -1 (disable feature) for reloption. Opinions?
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-03-25 20:32:15 | Re: plan cache overhead on plpgsql expression |
| Previous Message | Alvaro Herrera | 2020-03-25 20:12:48 | Re: [DOC] Document concurrent index builds waiting on each other |