| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. |
| Date: | 2024-03-14 00:19:03 |
| Message-ID: | CAPpHfdss-+EZHUP_MMNm9wHm43+ZM84ERWZvGO+p-5kH_Qt6og@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 11, 2024 at 11:48 AM Alexander Korotkov
<aekorotkov(at)gmail(dot)com> wrote:
>
> On Mon, Mar 11, 2024 at 5:43 AM Anton A. Melnikov
> <a(dot)melnikov(at)postgrespro(dot)ru> wrote:
> > On 11.03.2024 03:39, Alexander Korotkov wrote:
> > > Now that we distinguish stats for checkpoints and
> > > restartpoints, we need to update the docs. Please, check the patch
> > > attached.
> >
> > Maybe bring the pg_stat_get_checkpointer_buffers_written() description in consistent with these changes?
> > Like that:
> >
> > --- a/src/include/catalog/pg_proc.dat
> > +++ b/src/include/catalog/pg_proc.dat
> > @@ -5740 +5740 @@
> > - descr => 'statistics: number of buffers written by the checkpointer',
> > + descr => 'statistics: number of buffers written during checkpoints and restartpoints',
>
> This makes sense. I've included this into the revised patch.
Pushed.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-03-14 00:26:25 | Re: Improve readability by using designated initializers when possible |
| Previous Message | Thomas Munro | 2024-03-14 00:12:05 | Re: Volatile write caches on macOS and Windows, redux |