Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed
Date: 2017-12-08 21:49:57
Message-ID: CAPpHfdsY=9ZM6YpE-kSgY4EdX8g3yOb8dN=fOyktaq1ttBHYnw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Mon, Nov 27, 2017 at 10:18 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
wrote:

> I though about this design more time. I see following disadvantages
>
> 1. we are not able to check all possible variants of extended query. If
> there will be some custom error, then we will raise pretty ugly error
> messages,
>

Yes, that's an inevitable shortcoming. psql is not backend and can't
perform all the required checks on its side...

2. I don't thing so using "Size" as table size in human readable format and
> "size" as table size in raw format is intuitive, but any change of "Size"
> can introduce some (less probability compatibility issues),
>

Oh, this is surprisingly hard problem which probably have only imperative
solution...

3. What queries will contains size calculations? It is not cheap - requires
> AccessShareLock
>

Sorry, I didn't understand this point. Yes, size calculation requires
locking, but that is already true for \dt+ and \l+. Why this is
disadvantage of proposed approach?

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2017-12-08 21:56:03 Re: Add %r substitution for psql prompts to show recovery status
Previous Message Andres Freund 2017-12-08 21:44:37 Faster str to int conversion (was Table with large number of int columns, very slow COPY FROM)