Re: Doc patch for index access method function

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Doc patch for index access method function
Date: 2018-08-10 11:27:52
Message-ID: CAPpHfdsMLwS+DVAqQPGEtpUDGTk4omh=_Ux3TkVZUSYJrVn-1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 10, 2018 at 1:37 PM Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> On Fri, Aug 10, 2018 at 6:24 AM Tatsuro Yamada
> <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> >
> > Attached patch for fixing documents of "61.2. Index Access Method Functions" and
> > "61.6. Index Cost Estimation Functions".
> >
> > I added a variable "double *indexPages" introduced by commit 5262f7a4f to the documents and
> > also added its explanation. Please read and revise it because I'm a non-native English speaker.
>
> Good catch. It was overseen in 5262f7a4fc44, where parallel index
> scan was introduced.
>
> "This is used to adjust the estimate for the cost of the disk access."
>
> This sentence doesn't look correct for me. Cost of the disk access is
> estimated inside amcostestimate(). As I get, indexPages is used to
> estimate how effective parallel scan would be, because different
> workers pick different leaf pages. I'm going to adjust this sentence
> and commit this fix.

Pushed.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-08-10 11:50:49 Re: pgbench exit code
Previous Message Marina Polyakova 2018-08-10 10:39:49 Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors