Re: [PATCH] reduce page overlap of GiST indexes built using sorted method

Hi!

On Wed, Jan 26, 2022 at 7:07 PM sergei sh. <sshoulbakov(at)kontur(dot)io> wrote:
> I've fixed issues 2 -- 4 in attached version.
>
> GUC parameter has been removed for the number of pages to collect
> before splitting and fixed value of 4 is used instead, as discussed
> off-list with Andrey Borodin, Aliaksandr Kalenik, Darafei
> Praliaskouski. Benchmarking shows that using higher values has almost
> no effect on query efficiency while increasing index building time.
>
> PSA graphs for index creation and query time, "tiling" and "self-join"
> refer to queries used in previous benchmarks:
> https://github.com/mngr777/pg_index_bm2
>
> Sorted build method description has been added in GiST README.

Thank you for the revision. This patch looks good to me. I've
slightly adjusted comments and formatting and wrote the commit
message.

I'm going to push this if no objections.

------
Regards,
Alexander Korotkov