Re: Possible problem in Custom Scan API

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>
Subject: Re: Possible problem in Custom Scan API
Date: 2017-04-12 05:47:18
Message-ID: CAPpHfds8raXh7w5_LAZwt0ULiyZaKH7xO5CgRzSU2J9pTyStDg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 12, 2017 at 12:59 AM, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>
wrote:

> Tom Lane wrote:
>
>> Uh, no, construction of a custom plan node is entirely driven by the
>> PlanCustomPath method as far as I can see. You're free to ignore what
>> create_scan_plan did and insert your own tlist.
>>
>
> Are you sure? Even if it's true, this targetlist should still contain each
> and every Var that's been requested. If I'm correct, the only way to ensure
> that is to call build_path_tlist(), which is static (oops!). Perhaps I
> could make my own, but it uses replace_nestloop_params() (again, static),
> and the problem goes further and further.
>

As I understand, making build_path_tlist a non-static function would solve
the problem.
Tom, do you think it's possible?

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Harris 2017-04-12 05:49:51 Re: pg_basebackup: Allow use of arbitrary compression program
Previous Message Kuntal Ghosh 2017-04-12 05:34:04 Re: Why does logical replication launcher set application_name?