| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Allow specification of custom slot for custom nodes |
| Date: | 2022-11-21 20:50:10 |
| Message-ID: | CAPpHfds4fXCu+5o8TJfdCw3W+9Sp7W3egboXRRygOK35aTth-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
>
> I've looked at this patch and don't see any problems with it. It is minimally invasive, it doesn't affect functionality unless anyone (e.g. extension) sets its own slotOps in CustomScanState.
> Furthermore, the current patch very slightly modifies patch 0b03e5951bf0 with the intention of introducing extensibility. So I think adding more extensibility regarding different tuple formats is an excellent thing to do.
>
> I'm going to mark it as RfC if there are no objections.
Thank you for your feedback. I also don't see how this patch could
affect anybody.
I'm going to push this if there are no objections.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-11-21 20:50:57 | Re: More efficient build farm animal wakeup? |
| Previous Message | Laurenz Albe | 2022-11-21 20:50:08 | Re: Reducing power consumption on idle servers |