Re: Further cleanup related to statistics import support in postgres_fdw

On Sun, Sep 6, 2026 at 7:45 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Sat, Sep 5, 2026 at 1:23 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > We are really nearing the end of the beta stabilization phase, I feel
> > like just adding the note like this:
> >
> > "Note that if the remote table was inherited in the past, postgres_fdw
> > currently considers it inherited even if it is not currently
> > inherited. This restriction might be fixed in a future release."
>
> I expanded this to something like the attached.

Upon reconsideration, I think it's better to adjust the WARNING
message like this, rather than just adding the lengthy note.

ereport(WARNING,
errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
- errmsg("could not import statistics
for foreign table \"%s.%s\" --- remote table \"%s.%s\" is inherited",
+ errmsg("could not import statistics
for foreign table \"%s.%s\" --- remote table \"%s.%s\" is (or was
once) inherited",
local_schemaname, local_relname,
remote_schemaname, remote_relname));

Attached is an updated patch for that, in which I simplified a near-by
code comment as well as that note. Comments welcome!

Best regards,
Etsuro Fujita