Re: Use-after-free issue in postgres_fdw

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use-after-free issue in postgres_fdw
Date: 2026-05-01 12:05:57
Message-ID: CAPmGK17GMMhicN=robRpohYz=qVXD=cjTrCMMkTdhjQbkRaHPA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 27, 2026 at 5:07 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Apr 24, 2026 at 01:59:22AM -0700, Etsuro Fujita wrote:
> > Right, this patch delays discarding the failed connection until abort
> > cleanup of the top transaction, so it is guaranteed that anyone that
> > uses it can safely refer to its PGconn when needed.
>
> +-- test handling of abort-cleanup-failed connections
>
> Perhaps this could be more descriptive, like "test cleanup of failed
> connections on abort"?

Sounds better. I'll modify the comment as such, and if no objections,
push an updated version and back-patch it to all supported versions.

Thanks for the comments!

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Phil Florent 2026-05-01 13:24:51 RE: First draft of PG 19 release notes
Previous Message Amit Kapila 2026-05-01 10:41:39 Re: [PATCH] Fix stale relation close in sequence synchronization