Re: [PG19][PATCH] Make postgres_fdw statistics import atomic

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Nikolay Samokhvalov <nik(at)postgres(dot)ai>
Cc: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ashutosh(dot)bapat(dot)oss(at)gmail(dot)com
Subject: Re: [PG19][PATCH] Make postgres_fdw statistics import atomic
Date: 2026-09-18 09:15:14
Message-ID: CAPmGK16wgs7+ZSJ79yBdV+0m_kS9z258aEpKPjj5pOvQTjoQVA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 18, 2026 at 12:35 AM Nikolay Samokhvalov <nik(at)postgres(dot)ai> wrote:
> On Thu, Sep 17, 2026, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > * You imported remote stats without re-analyzing the remote table
> > after the delete operation, but that isn't supported, as noted in the
> > documentation; "When using this option, it is the user's
> > responsibility to ensure that the existing statistics for the remote
> > table are up-to-date."
>
> Thanks Etsuro. Agreed, my reproducer violates that requirement.
> I haven't reproduced this with matching types and current remote
> stats, so I'll withdraw the patch for now.
>
> Attribute stats can still affect join estimates when reltuples=0;
> I tested that. But that doesn't show this needs fixing.

Ok, I will move this open item to Non-bugs if no objections.

Thanks for checking!

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-09-18 09:16:05 Re: SHMEM_ATTACH_UNKNOWN_SIZE reaches InitShmemIndexEntry()
Previous Message Pavel Stehule 2026-09-18 09:06:13 Re: different result of regexp_instr than on Oracle