Re: Unmatched test and comment in partition_join.sql regression test

On Fri, Dec 13, 2019 at 7:17 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> I noticed this in the regression test while polishing the PWJ-enhancement patch:
>
> -- partitionwise join can not be applied for a join between list and range
> -- partitioned tables
> EXPLAIN (COSTS OFF)
> SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 FULL JOIN prt1 t2 ON (t1.c = t2.c);
>
> The test doesn't match the comment which precedes it, because both
> tables are range-partitioned as shown below.

> I think the test should be moved to a more appropriate place,

On second thought I changed my mind; we would not need to move that
test, so I refrained from doing so.

> Attached is a patch for that. The
> patch fixes another misplaced comment as well.

I pushed an updated version of the patch.

Best regards,
Etsuro Fujita