Re: Problem with transition tables on partitioned tables with foreign-table partitions

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Problem with transition tables on partitioned tables with foreign-table partitions
Date: 2025-08-08 09:17:35
Message-ID: CAPmGK16v6qAxCpPdt6BU3+9ueuVRV3iT1DBg6x6vUQT7GU0uwA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 14, 2025 at 8:00 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> After re-reading the patch I noticed two minor things:
>
> * The existing code in ExecAR* functions already dereferences the
> passed-in ResultRelInfo pointer without checking that it is not NULL.
> The Assert I added to those functions would be an overkill, so I
> removed it. Sorry for the back and forth.
>
> * I added a trigger function trigger_nothing() in the regression
> tests, but I noticed an existing trigger function above the tests. To
> make the tests a bit small, I replaced trigger_nothing() with the
> existing trigger function and removed trigger_nothing().
>
> Attached is a new version of the patch.

I have pushed this and back-patched it to all supported versions.

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2025-08-08 09:19:55 Re: Odd behavior of statement triggers with transition tables on partitions
Previous Message Heikki Linnakangas 2025-08-08 09:09:27 Re: BackendKeyData is mandatory?