Re: BUG #17355: Server crashes on ExecReScanForeignScan in postgres_fdw when accessing foreign partition

Hi Amit-san,

On Wed, Feb 2, 2022 at 11:06 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Feb 2, 2022 at 7:55 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > On Wed, Feb 2, 2022 at 12:59 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > BTW, isn't the following code in ForeignNext() added by c3928b467
> > > non-reachable after your patch:
> > >
> > > /*
> > > * direct modifications cannot be re-evaluated, so shouldn't get here
> > > * during EvalPlanQual processing
> > > */
> > > if (estate->es_epq_active != NULL)
> > > elog(ERROR, "cannot re-evaluate a Foreign Update or Delete
> > > during EvalPlanQual");
> > >
> > > Should that be converted to an Assert(estate->es_epq_active == NULL)?
> >
> > +1 I updated the patch as such. Attached is a new version. I also
> > tweaked a comment a litttle bit further.

> Thanks, looks good to me.

Ok, I have committed the patch.

Thanks again!

Best regards,
Etsuro Fujita