| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Etsuro Fujita <efujita(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: naming of async_mode parameter |
| Date: | 2021-05-16 14:10:49 |
| Message-ID: | CAPmGK16XNhp0n=T=cVt0bHNZiHOrKQyZvHEEJFSbwZBF3NbTWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, May 14, 2021 at 9:00 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> Searching postgres codebase reveals the following (partial) examples:
>
> bool is_varlena
> bool is_leaf
>
> I think these are more intuitive.
>
> If you think is_in_async_mode is too long, how about naming the parameter is_async ?
Sorry, I don’t think we need to rename the parameter, because I think
async_mode is also a good name for it, and the naming follows that of
existing parameters in our codebase, such as hash_spill_mode and
csv_mode in the CopyFormatOptions struct.
I think this would be just a matter of preference.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2021-05-16 14:39:14 | Re: Asynchronous Append on postgres_fdw nodes. |
| Previous Message | Tatsuo Ishii | 2021-05-16 13:29:30 | Re: Typo in README.barrier |