From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Obsolete comment in partbounds.c |
Date: | 2019-10-18 07:25:03 |
Message-ID: | CAPmGK16Uxr=PatiGyaRwiQVLB7Y-GqbkK3AxRLVYzU0Czv=sEw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
While reviewing the partitionwise-join patch, I noticed $Subject,ie,
this in create_list_bounds():
/*
* Never put a null into the values array, flag instead for
* the code further down below where we construct the actual
* relcache struct.
*/
if (null_index != -1)
elog(ERROR, "found null more than once");
null_index = i;
"the code further down below where we construct the actual relcache
struct" isn't in the same file anymore by refactoring by commit
b52b7dc25. How about modifying it like the attached?
Best regards,
Etsuro Fujita
Attachment | Content-Type | Size |
---|---|---|
fix-obsolete-comment.patch | application/octet-stream | 707 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2019-10-18 07:51:55 | Re: generating catcache control data |
Previous Message | Dilip Kumar | 2019-10-18 06:48:35 | Re: [HACKERS] Block level parallel vacuum |