| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Defer selection of asynchronous subplans until the executor initialization stage |
| Date: | 2022-04-25 04:29:16 |
| Message-ID: | CAPmGK16EKa_v_viZ5yqbbMSU00=GUgX2PYyqDZKgmagwaY6i7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Apr 20, 2022 at 2:04 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> It is okay to keep the formation in your patch.
I modified mark_async_capable_plan() a bit further; 1) adjusted code
in the ProjectionPath case, just for consistency with other cases, and
2) tweaked/improved comments a bit. Attached is a new version of the
patch (“prevent-async-2.patch”).
As mentioned before, v14 has the same issue, so I created a fix for
v14, which I’m attaching as well (“prevent-async-2-v14.patch”). In
the fix I modified is_async_capable_path() the same way as
mark_async_capable_plan() in HEAD, renaming it to
is_async_capable_plan(), and updated some comments.
Barring objections, I’ll push/back-patch these.
Thanks!
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| prevent-async-2.patch | application/octet-stream | 6.7 KB |
| prevent-async-2-v14.patch | application/octet-stream | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | alias | 2022-04-25 05:11:42 | json_object returning jsonb reuslt different from returning json, returning text |
| Previous Message | Nathan Bossart | 2022-04-25 01:27:22 | Re: [Proposal] vacuumdb --schema only |