Re: Typo in version check in postgresAcquireSampleRowsFunc

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Typo in version check in postgresAcquireSampleRowsFunc
Date: 2026-09-30 10:49:52
Message-ID: CAPmGK16E0o1AUpe=kt5Odo6u-2jVpKTgYkefBaEL0TrWagGfyw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 28, 2026 at 8:49 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> LGTM. 90500 is for 9.5, there is 90600 for 9.6 also less than 95000.

Yeah, this causes an unexpected error when the remote server is 9.5 or 9.6:

alter foreign table ft1 options (add analyze_sampling 'bernoulli');
analyze ft1;
ERROR: remote server does not support TABLESAMPLE feature

Will push. Thanks for looking!

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2026-09-30 10:50:59 Re: Typo in version check in postgresAcquireSampleRowsFunc
Previous Message Etsuro Fujita 2026-09-30 10:45:48 Re: postgres_fdw: transaction mode inheritance corner cases