Re: a comment in joinrel.c: compute_partition_bounds()

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: a comment in joinrel.c: compute_partition_bounds()
Date: 2021-09-24 07:20:24
Message-ID: CAPmGK168z05usEDecauLc3iBz6pPGYZJY4SMe+56JDZHtSFC+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amit-san,

On Fri, Sep 24, 2021 at 3:34 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> I think there's a word missing in the following comment:
>
> /*
> * See if the partition bounds for inputs are exactly the same, in
> * which case we don't need to work hard: the join rel have the same
> * partition bounds as inputs, and the partitions with the same
> * cardinal positions form the pairs.
>
> ": the join rel have the same..." seems to be missing a "will".
>
> Attached a patch to fix.

Good catch! Will fix.

Thanks!

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-09-24 07:50:35 Re: Gather performance analysis
Previous Message Dilip Kumar 2021-09-24 06:49:15 Re: row filtering for logical replication