Re: postgres_fdw: batch inserts vs. before row triggers

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: batch inserts vs. before row triggers
Date: 2022-08-05 08:36:22
Message-ID: CAPmGK15onjpkn08k=TNvEuB2BR3_TaLTuH=DE9caFuCPghKzgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 3, 2022 at 2:24 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> To fix, I modified postgresGetForeignModifyBatchSize() to disable
> batch insert when there are any such constraints, like when there are
> any AFTER ROW triggers on the foreign table. Attached is a patch for
> that.
>
> If there are no objections, I'll commit the patch.

Pushed after modifying the patch a bit so that in that function the
WCO test in the if test is done before the trigger test, as the former
would be cheaper than the latter.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-08-05 08:40:01 Re: Patch to address creation of PgStat* contexts with null parent context
Previous Message Kyotaro Horiguchi 2022-08-05 08:22:38 Re: Patch to address creation of PgStat* contexts with null parent context