| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Comment about set_join_pathlist_hook() |
| Date: | 2023-09-20 10:05:31 |
| Message-ID: | CAPmGK15SBPA1nr3Aqsdm+YyS-ay0Ayo2BRYQ8_A2To9eLqwopQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
What I am concerned about from the report [1] is that this comment is
a bit too terse; it might cause a misunderstanding that extensions can
do different things than we intend to allow:
/*
* 6. Finally, give extensions a chance to manipulate the path list.
*/
if (set_join_pathlist_hook)
set_join_pathlist_hook(root, joinrel, outerrel, innerrel,
jointype, &extra);
So I would like to propose to extend the comment to explain what they
can do, as in the comment about set_rel_pathlist_hook() in allpaths.c.
Attached is a patch for that.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| update-set_join_pathlist_hook-comment.patch | application/octet-stream | 746 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-09-20 10:11:29 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Yuya Watari | 2023-09-20 10:04:46 | Re: [PoC] Reducing planning time when tables have many partitions |